Re: [Qemu-devel] [PATCH] hw/vmmouse.c: Fix to disable vmmouse after reboot

[Andreas Färber]

Am 08.01.2012 13:01, schrieb Gerhard Wiesinger:
> On Wed, 4 Jan 2012, Gerhard Wiesinger wrote:
> 
>> Testscenario:
>> 1.) Boot e.g. OS with VMMouse support (e.g. Windows)
>> 2.) reboot
>> 3.) Boot e.g. OS without VMMouse support (e.g. DOS) => PS/2 mouse
>> doesn't work any more. Fixes that issue.
>>
>> Reason is that VMMouse has priority and disables all other mouse
>> entities and therefore must be disabled on reset.
> 
> Any further comments before integrating the patch?

I implicitly asked you for a more verbose commit message.

For example, based on the info you provided as a reply above:

--8<--
hw/vmmouse.c: Disable vmmouse on reboot

When a guest activated the vmmouse, following a reboot the vmmouse
stayed enabled and the PS/2 mouse was unusable. That way, when rebooting
to guests without vmmouse support the mouse would not work.

Fix this by disabling the vmmouse in its reset handler.
--8<--

I have it queued for testing tomorrow - I am hoping this will fix a
0.15.1 mouse issue after kdump as well.

As a bugfix, it would definitely be a candidate for stable-1.0.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg