Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

[Marek Vasut]

> On 8 January 2012 16:02, Marek Vasut <address@hidden> wrote:
> >> Can you point me to some documentation? I looked at
> >> http://cache.freescale.com/files/dsp/doc/ref_manual/MCIMX28RM.pdf?fsrch=
> >> 1&s r=7 (i.MX28 Applications Processor Reference Manual) and although it
> >> has a number of UARTs none of them looked obviously like PL011s.
> > 
> > That's it, look at DUART section and Memory map section.
> 
> That doesn't document that it implements the ID registers at all :-)

Well ... can't be helped.

> Does the hardware give the ID registers the same values as stock
> PL011 or are the part number/designer/etc fields different?

Slightly different, but compatible with Linux:

80075fe0: 00000011 00000010 00000024 00000000    ........$.......
80075ff0: 0000000d 000000f0 00000005 000000b1    ................
> 
> Anyway, the right approach to this is going to be to have either
> (a) a qdev device with a different name [this is how we handle
> the pl061 variant in the Stellaris Luminary, for instance]
> (b) qdev properties
> so you can get the mx28 right.

This seems more correct/extensible approach.

M

> 
> -- PMM