Re: [Qemu-devel] [PATCH 1/1] hw: Add IGEPv2 board support

[Javier Martinez Canillas]

On Wed, Jan 11, 2012 at 12:15 PM, Peter Maydell
<address@hidden> wrote:
> On 11 January 2012 08:43, Javier Martinez Canillas <address@hidden> wrote:
>> Add ISEE IGEPv2 board definition (an OMAP3730 based board).
>>
>> Signed-off-by: Javier Martinez Canillas <address@hidden>
>

Hello Peter,

> It's polite to mention that patches are against qemu-linaro if you cc
> qemu-devel.
>

Yes, you are right. Sorry for not mention that in the patch.

> So my initial reaction to this is to ask what the benefit is of adding another
> basically-just-an-OMAP3 model. We already have beagle and overo,
> and this is obviously just cut-n-paste from overo (it still has the comment
> about "FAB revisions" which is specific to Overo, which doesn't give me a
> great deal of confidence that this is actually correctly modelling the IGEPv2
> rather than just something random which happens to be able to boot an
> IGEPv2 kernel...)
>

Yes, the IGEPv2 and the Overo are indeed very similar machines so we
base the hardware modeling on the Overo.

The only differences here are which OMAP version is used to initialize
the MPU (3630 instead of 3430) and the NAND memory used, Numonyx
OneNAND instead of Micron NAND.

What is the benefit to have yet another OMAP3 device? Well.. I don't know ;-)

We just add this device model for our clients so I thought it was a
good idea to post the patch upstream. But feel free to ignore me if
you think that it doesn't add any value to Linaro QEMU.

> GPLv2-only rather than v2-or-later is also going to be a problem, although
> I appreciate that that's because you've based this on the v2-only overo.c
> [which is going to be a problem for me later on when I try to upstream that 
> :-)]
>
> -- PMM
>

Sorry about that, I didn't know that GPLv2 or later was the norm in
the QEMU project.

Also, is good to notice that the Versatile Express board
(hw/vexpress.c) and the StrongARM emulation support (hw/strongarm.c)
also use GPLv2-only license. If you need to fix those too.

Thanks a lot and best regards,
Javier