Re: [Qemu-devel] [PATCH 10/10] fdc: DIR (Digital Input Register) should return status of current drive...

[Andreas Färber]

Am 08.01.2012 21:27, schrieb Hervé Poussineau:
> 
> Signed-off-by: Hervé Poussineau <address@hidden>
> ---
>  hw/fdc.c |    9 ++-------
>  1 files changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/hw/fdc.c b/hw/fdc.c
> index 7af0f7e..a23fb1e 100644
> --- a/hw/fdc.c
> +++ b/hw/fdc.c

> @@ -932,13 +933,7 @@ static uint32_t fdctrl_read_dir(FDCtrl *fdctrl)
>  {
>      uint32_t retval = 0;
>  
> -    if (fdctrl_media_changed(drv0(fdctrl))
> -     || fdctrl_media_changed(drv1(fdctrl))
> -#if MAX_FD == 4
> -     || fdctrl_media_changed(drv2(fdctrl))
> -     || fdctrl_media_changed(drv3(fdctrl))
> -#endif
> -        )
> +    if (fdctrl_media_changed(get_cur_drv(fdctrl)))
>          retval |= FD_DIR_DSKCHG;

Braces :) (Most famous review comment...)

Andreas

>      if (retval != 0) {
>          FLOPPY_DPRINTF("Floppy digital input register: 0x%02x\n", retval);

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg