Re: [Qemu-devel] [PATCH v4 04/15] block: add image streaming block job

[Stefan Hajnoczi]

On Wed, Jan 11, 2012 at 03:18:28PM -0200, Luiz Capitulino wrote:
> On Fri,  6 Jan 2012 14:01:30 +0000
> Stefan Hajnoczi <address@hidden> wrote:
> > +int stream_start(BlockDriverState *bs, BlockDriverState *base,
> > +                 BlockDriverCompletionFunc *cb, void *opaque)
> > +{
> > +    StreamBlockJob *s;
> > +    Coroutine *co;
> > +
> > +    if (bs->job) {
> > +        return -EBUSY;
> > +    }
> > +
> > +    s = block_job_create(&stream_job_type, bs, cb, opaque);
> > +    s->base = base;
> 
> This is missing a check against NULL.

Good catch.