qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/3] stop the periodic RTC update timer


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 3/3] stop the periodic RTC update timer
Date: Thu, 12 Jan 2012 10:26:17 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0

On 01/12/2012 01:00 AM, Zhang, Yang Z wrote:
Regarding the UIP bit, a guest could read it in a loop and wait
for the value to change. But you can emulate it in
cmos_ioport_read by reading the host time, that is, return 1
during 244us, 0 for remaining of the second, and have that in
sync with update-cycle-ended interrupt if its enabled.

Yes. Guest may use the loop to read RTC, but the point is the guest
is waiting for the UIP changed to 0. If this bit always equal to 0 ,
guest will never go into the loop. For real RTC, this may wrong,
because the RTC cannot give you the valid value during the update
cycle. But the virtual RTC doesn't' need this logic, whenever you
read it, it will always return the right value to you.

The point is not _correctness_.  It is _atomicity_.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]