[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 04/15] block: add image streaming block job
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 04/15] block: add image streaming block job |
|
Date: |
Thu, 12 Jan 2012 11:39:13 +0000 |
On Thu, Jan 12, 2012 at 10:59 AM, Kevin Wolf <address@hidden> wrote:
> Am 06.01.2012 15:01, schrieb Stefan Hajnoczi:
>> + buf = qemu_blockalign(bs, STREAM_BUFFER_SIZE);
>> + s->common.len = bdrv_getlength(bs);
>
> No error check?
Will fix.
>> + bdrv_get_geometry(bs, (uint64_t *)&end);
>
> Why call bdrv_getlength() twice? end = s->common.len >> BDRV_SECTOR_BITS
> should be the same.
Okay, I'll change it. I got sick of BDRV_SECTOR_* and called twice instead.
- [Qemu-devel] [PATCH v4 02/15] block: check bdrv_in_use() before blockdev operations, (continued)
- [Qemu-devel] [PATCH v4 02/15] block: check bdrv_in_use() before blockdev operations, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH v4 03/15] block: add BlockJob interface for long-running operations, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH v4 07/15] qmp: add block_job_set_speed command, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH v4 06/15] qmp: add block_stream command, Stefan Hajnoczi, 2012/01/06
- [Qemu-devel] [PATCH v4 04/15] block: add image streaming block job, Stefan Hajnoczi, 2012/01/06
[Qemu-devel] [PATCH v4 10/15] blockdev: make image streaming safe across hotplug, Stefan Hajnoczi, 2012/01/06
[Qemu-devel] [PATCH v4 05/15] block: rate-limit streaming operations, Stefan Hajnoczi, 2012/01/06
[Qemu-devel] [PATCH v4 09/15] qmp: add query-block-jobs, Stefan Hajnoczi, 2012/01/06
[Qemu-devel] [PATCH v4 08/15] qmp: add block_job_cancel command, Stefan Hajnoczi, 2012/01/06