Re: [Qemu-devel] [PATCH v9 5/6] arm: SoC model for Calxeda Highbank

[Peter Maydell]

On 12 January 2012 13:42, Mitsyanko Igor <address@hidden> wrote:
> On 01/12/2012 05:09 PM, Andreas Färber wrote:
>> Depends on how you read this:
>>
>> /* Legacy helper function for creating devices.  */
>> DeviceState *sysbus_create_varargs(const char *name,
>>                                  target_phys_addr_t addr, ...);
>> DeviceState *sysbus_try_create_varargs(const char *name,
>>                                        target_phys_addr_t addr, ...);
>> static inline DeviceState *sysbus_create_simple(const char *name,
>>                                               target_phys_addr_t addr,
>>                                               qemu_irq irq)
>> {
>>     return sysbus_create_varargs(name, addr, irq, NULL);
>> }
>>
>> I interpret it as sysbus_create_simple() using deprecated
>> sysbus_create_varargs() and therefore being deprecated, too.

> Sorry, never paid attention that these functions are deprecated.

Personally I don't think we should deprecate either
sysbus_create_simple() or sysbus_create_varargs() until QOM has
advanced to the point where we can throw out sysbus devices altogether.
These functions are a straightforward way of instantiating simple
sysbus devices, they're widely used, and I don't see anything
particularly wrong with them.

-- PMM