[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] build: fix target_phys_addr_t to 64-bit
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] build: fix target_phys_addr_t to 64-bit |
Date: |
Fri, 13 Jan 2012 01:13:33 +0000 |
On 12 January 2012 23:47, Andreas Färber <address@hidden> wrote:
> PRI* should never include % or width specifier or prefix.
>
> What we should IMO do is:
>
> #define PRIdPLX PRId64
> #define PRIxPLX PRIx64
> #define PRIXPLX PRIX64
> /* or TARGET_PRI*PHYS or whatever */
>
> This can then be used as "... %02" PRIxPLX for shortened output.
Yes, I like this -- it's using the PRI* as a way of getting
"right format specifier for the type" without imposing the
width etc on the user, and it lines up with the standard
PRI* macros rather than being an oddity like TARGET_FMT_plx
is at the moment.
-- PMM
- [Qemu-devel] [PATCH] build: fix target_phys_addr_t to 64-bit, Anthony Liguori, 2012/01/12
- Re: [Qemu-devel] [PATCH] build: fix target_phys_addr_t to 64-bit, Andreas Färber, 2012/01/12
- Re: [Qemu-devel] [PATCH] build: fix target_phys_addr_t to 64-bit, Peter Maydell, 2012/01/12
- Re: [Qemu-devel] [PATCH] build: fix target_phys_addr_t to 64-bit, Anthony Liguori, 2012/01/12
- Re: [Qemu-devel] [PATCH] build: fix target_phys_addr_t to 64-bit, Peter Maydell, 2012/01/12
- Re: [Qemu-devel] [PATCH] build: fix target_phys_addr_t to 64-bit, Peter Maydell, 2012/01/12
- Re: [Qemu-devel] [PATCH] build: fix target_phys_addr_t to 64-bit, Anthony Liguori, 2012/01/12
- Re: [Qemu-devel] [PATCH] build: fix target_phys_addr_t to 64-bit, Peter Maydell, 2012/01/12
- Re: [Qemu-devel] [PATCH] build: fix target_phys_addr_t to 64-bit, Andreas Färber, 2012/01/12
- Re: [Qemu-devel] [PATCH] build: fix target_phys_addr_t to 64-bit,
Peter Maydell <=