qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 2/2] virtio-console: no need to remove char handlers


From: Amit Shah
Subject: [Qemu-devel] [PATCH 2/2] virtio-console: no need to remove char handlers explicitly
Date: Fri, 13 Jan 2012 15:24:59 +0530

qdev is now equipped (thanks to the last commit) to disassociate
chardevs from the qdev devices on the devices going away.  So doing it
in the virtio-console driver is not necessary.

Since that was the only thing being done in the qdev exit method, drop
it entirely.

Signed-off-by: Amit Shah <address@hidden>
---
 hw/virtio-console.c |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index 73d866a..9275fd9 100644
--- a/hw/virtio-console.c
+++ b/hw/virtio-console.c
@@ -127,16 +127,6 @@ static int virtconsole_initfn(VirtIOSerialPort *port)
 
 static int virtconsole_exitfn(VirtIOSerialPort *port)
 {
-    VirtConsole *vcon = DO_UPCAST(VirtConsole, port, port);
-
-    if (vcon->chr) {
-       /*
-        * Instead of closing the chardev, free it so it can be used
-        * for other purposes.
-        */
-       qemu_chr_add_handlers(vcon->chr, NULL, NULL, NULL, NULL);
-    }
-
     return 0;
 }
 
-- 
1.7.7.5




reply via email to

[Prev in Thread] Current Thread [Next in Thread]