[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 04/12] vvfat: avoid leaking file descriptor in commi
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 04/12] vvfat: avoid leaking file descriptor in commit_one_file() |
Date: |
Fri, 13 Jan 2012 10:51:32 +0000 |
Reported-by: Dr David Alan Gilbert <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
block/vvfat.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index eeffc4a..9ef21dd 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -2218,6 +2218,7 @@ static int commit_one_file(BDRVVVFATState* s,
}
if (offset > 0) {
if (lseek(fd, offset, SEEK_SET) != offset) {
+ close(fd);
g_free(cluster);
return -3;
}
@@ -2238,11 +2239,13 @@ static int commit_one_file(BDRVVVFATState* s,
(uint8_t*)cluster, (rest_size + 0x1ff) / 0x200);
if (ret < 0) {
+ close(fd);
g_free(cluster);
return ret;
}
if (write(fd, cluster, rest_size) < 0) {
+ close(fd);
g_free(cluster);
return -2;
}
--
1.7.7.3
- [Qemu-devel] [PULL 00/12] Trivial patches for 6 to 13 January 2012, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 05/12] vnc: fix no-lock-key-sync strncmp() length, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 01/12] configure: Modify detection of supported warning options, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 02/12] tcg-arm: fix a typo in comments, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 03/12] Spelling fixes in comments and documentation, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 04/12] vvfat: avoid leaking file descriptor in commit_one_file(),
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 10/12] virtfs-proxy-helper: Clean include files, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 06/12] omap_dss: correct chip[1] index in RFBI_READ/RFBI_STATUS, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 11/12] virtfs-proxy-helper: Add missing printf format attribute, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 09/12] virtfs-proxy-helper: Fix compilation on newer systems, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 12/12] bt-host: add missing break statement, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 07/12] Add 'fall through' comments to case statements without break, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 08/12] hmp: Fix freeing of PciInfoList, Stefan Hajnoczi, 2012/01/13
- Re: [Qemu-devel] [PULL 00/12] Trivial patches for 6 to 13 January 2012, Anthony Liguori, 2012/01/13