[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 06/12] omap_dss: correct chip[1] index in RFBI_READ/
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 06/12] omap_dss: correct chip[1] index in RFBI_READ/RFBI_STATUS |
Date: |
Fri, 13 Jan 2012 10:51:34 +0000 |
The RFBI_READ/RFBI_STATUS code incorrectly uses chip[0] when it should
be using chip[1]. Andrzej Zaborowski <address@hidden> confirmed this
bug since I don't know this code well.
Reported-by: Dr David Alan Gilbert <address@hidden>
Reviewed-by: Andrzej Zaborowski <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
hw/omap_dss.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/omap_dss.c b/hw/omap_dss.c
index ede640b..86ed6ea 100644
--- a/hw/omap_dss.c
+++ b/hw/omap_dss.c
@@ -793,7 +793,7 @@ static void omap_rfbi_write(void *opaque,
target_phys_addr_t addr,
if ((s->rfbi.control & (1 << 2)) && s->rfbi.chip[0])
s->rfbi.rxbuf = s->rfbi.chip[0]->read(s->rfbi.chip[0]->opaque, 1);
else if ((s->rfbi.control & (1 << 3)) && s->rfbi.chip[1])
- s->rfbi.rxbuf = s->rfbi.chip[0]->read(s->rfbi.chip[0]->opaque, 1);
+ s->rfbi.rxbuf = s->rfbi.chip[1]->read(s->rfbi.chip[1]->opaque, 1);
if (!-- s->rfbi.pixels)
omap_rfbi_transfer_stop(s);
break;
@@ -802,7 +802,7 @@ static void omap_rfbi_write(void *opaque,
target_phys_addr_t addr,
if ((s->rfbi.control & (1 << 2)) && s->rfbi.chip[0])
s->rfbi.rxbuf = s->rfbi.chip[0]->read(s->rfbi.chip[0]->opaque, 0);
else if ((s->rfbi.control & (1 << 3)) && s->rfbi.chip[1])
- s->rfbi.rxbuf = s->rfbi.chip[0]->read(s->rfbi.chip[0]->opaque, 0);
+ s->rfbi.rxbuf = s->rfbi.chip[1]->read(s->rfbi.chip[1]->opaque, 0);
if (!-- s->rfbi.pixels)
omap_rfbi_transfer_stop(s);
break;
--
1.7.7.3
- [Qemu-devel] [PULL 00/12] Trivial patches for 6 to 13 January 2012, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 05/12] vnc: fix no-lock-key-sync strncmp() length, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 01/12] configure: Modify detection of supported warning options, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 02/12] tcg-arm: fix a typo in comments, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 03/12] Spelling fixes in comments and documentation, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 04/12] vvfat: avoid leaking file descriptor in commit_one_file(), Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 10/12] virtfs-proxy-helper: Clean include files, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 06/12] omap_dss: correct chip[1] index in RFBI_READ/RFBI_STATUS,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 11/12] virtfs-proxy-helper: Add missing printf format attribute, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 09/12] virtfs-proxy-helper: Fix compilation on newer systems, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 12/12] bt-host: add missing break statement, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 07/12] Add 'fall through' comments to case statements without break, Stefan Hajnoczi, 2012/01/13
- [Qemu-devel] [PATCH 08/12] hmp: Fix freeing of PciInfoList, Stefan Hajnoczi, 2012/01/13
- Re: [Qemu-devel] [PULL 00/12] Trivial patches for 6 to 13 January 2012, Anthony Liguori, 2012/01/13