qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] linux-user: fix segfault deadlock


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] linux-user: fix segfault deadlock
Date: Fri, 13 Jan 2012 16:16:21 +0000

On 13 January 2012 15:46, Alexander Graf <address@hidden> wrote:
> When entering the guest we take a lock to ensure that nobody else messes
> with our TB chaining while we're doing it. If we get a segfault inside that
> code, we manage to work on, but will not unlock the lock.
>
> This patch forces unlocking of that lock in the segv handler. I'm not sure
> this is the right approach though. Maybe we should rather make sure we don't
> segfault in the code? I would greatly appreciate someone more intelligible
> than me to look at this :).

A segfault while we're walking the TB chains in QEMU C code?
That's just a bug (and we know we have one there) -- we should
fix it rather than papering over it like this.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]