Re: [Qemu-devel] [PATCH] kvm: flush the dirty log when unregistering a slot

[Jan Kiszka]

On 2012-01-15 15:17, Avi Kivity wrote:
> Otherwise, the dirty log information is lost in the kernel forever.
> 
> Fixes opensuse-12.1 boot screen, which changes the vga windows rapidly.

Confirmed, problems solved here.

Thanks,
Jan

> 
> Signed-off-by: Avi Kivity <address@hidden>
> ---
> 
> This patch gives me a deja vu - I'm sure I've fixed exactly the same issue
> before.
> 
> Please test.
> 
>  kvm-all.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/kvm-all.c b/kvm-all.c
> index 3174f42..2cc4562 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -566,6 +566,10 @@ static void kvm_set_phys_mem(MemoryRegionSection 
> *section, bool add)
>  
>          old = *mem;
>  
> +        if (mem->flags & KVM_MEM_LOG_DIRTY_PAGES) {
> +            kvm_physical_sync_dirty_bitmap(section);
> +        }
> +
>          /* unregister the overlapping slot */
>          mem->memory_size = 0;
>          err = kvm_set_user_memory_region(s, mem);
> -- 1.7.7.1
>

signature.asc
Description: OpenPGP digital signature