Re: [Qemu-devel] [PATCH] isapc: Fix segfault during initialization

[Jan Kiszka]

On 2012-01-15 17:12, Anthony Liguori wrote:
> On 01/15/2012 08:40 AM, Jan Kiszka wrote:
>> On 2012-01-15 15:38, Anthony Liguori wrote:
>>> On 01/14/2012 07:12 AM, Jan Kiszka wrote:
>>>> From: Jan Kiszka<address@hidden>
>>>>
>>>> Linking the RTC device state to the PIIX does not belong into the
>>>> common path that is shared with the isapc. QEMU crashes otherwise.
>>>>
>>>> Signed-off-by: Jan Kiszka<address@hidden>
>>>
>>> Does isapc actually work for you?  I tried to write a qemu-test test
>>> case (attached below) to help prevent future regressions.  I can
>>> reproduce your SEGV but with your patch applied, I get no output (not
>>> even the BIOS runs).
>>>
>>> Here's the command line.  Even a simple 'qemu-system-x86_64 -M isapc'
>>> reproduces it:
>>>
>>> /home/anthony/build/qemu/x86_64-softmmu/qemu-system-x86_64 -kernel
>>> bin/vmlinuz-3.0 -initrd .tmp-3510/initramfs-3510.img.gz -append
>>> console=ttyS0 seed=24689 -M isapc -pidfile .tmp-3510/pidfile-3510.pid
>>> -qmp unix:.tmp-3510/qmpsock-3510.sock,server,nowait
>>
>> You need to update seabios to the last release at least (should have
>> been done much earlier), and it only works for KVM (as that mode ignores
>> some ROM write protections where seabios obviously has some troubles
>> with).
> 
> Can you send a pull request?  SeaBIOS no longer builds on my laptop...

Will do. Last release of current master preferred?

Jan

signature.asc
Description: OpenPGP digital signature