qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/14] lm32: Fix mixup of uint32 and uint32_t


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH 01/14] lm32: Fix mixup of uint32 and uint32_t
Date: Mon, 16 Jan 2012 13:18:11 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111220 Thunderbird/9.0

Am 16.01.2012 12:27, schrieb Peter Maydell:
> On 16 January 2012 00:46, Andreas Färber <address@hidden> wrote:
>> diff --git a/hw/milkymist-vgafb_template.h b/hw/milkymist-vgafb_template.h
>> index 69af9ef..544b55e 100644
>> --- a/hw/milkymist-vgafb_template.h
>> +++ b/hw/milkymist-vgafb_template.h
>> @@ -39,7 +39,7 @@
>>  #elif BITS == 24
>>  #define COPY_PIXEL(to, r, g, b)                    \
>>     do {                                           \
>> -        uint32 tmp = rgb_to_pixel24(r, g, b);      \
>> +        uint32_t tmp = rgb_to_pixel24(r, g, b);      \
>>         *(to++) =         tmp & 0xff;              \
>>         *(to++) =  (tmp >> 8) & 0xff;              \
>>         *(to++) = (tmp >> 16) & 0xff;              \
> 
> This change breaks the otherwise consistent alignment of the '\'
> characters in column 51...

Thanks, will fix!

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]