Re: [Qemu-devel] [PATCH 01/14] lm32: Fix mixup of uint32 and uint32_t

[Michael Walle]

Am Montag 16 Januar 2012, 12:27:01 schrieb Peter Maydell:
> On 16 January 2012 00:46, Andreas Färber <address@hidden> wrote:
> > diff --git a/hw/milkymist-vgafb_template.h
> > b/hw/milkymist-vgafb_template.h index 69af9ef..544b55e 100644
> > --- a/hw/milkymist-vgafb_template.h
> > +++ b/hw/milkymist-vgafb_template.h
> > @@ -39,7 +39,7 @@
> >  #elif BITS == 24
> >  #define COPY_PIXEL(to, r, g, b)                    \
> >     do {                                           \
> > -        uint32 tmp = rgb_to_pixel24(r, g, b);      \
> > +        uint32_t tmp = rgb_to_pixel24(r, g, b);      \
> >         *(to++) =         tmp & 0xff;              \
> >         *(to++) =  (tmp >> 8) & 0xff;              \
> >         *(to++) = (tmp >> 16) & 0xff;              \
> 
> This change breaks the otherwise consistent alignment of the '\'
> characters in column 51...

apart from that,

Acked-by: Michael Walle <address@hidden>

-- 
michael