Re: [Qemu-devel] [PATCH 3/3] configure: add '--disable-cocoa' switch

[Peter Maydell]

On 16 January 2012 23:46, Andrzej Zaborowski
<address@hidden> wrote:
> On 14 January 2012 01:42, Andreas Färber <address@hidden> wrote:
>> Ping? Should we keep command line options a flat list with comments on
>> applicability or start introducing tests like above?
>>
>> Me, I'd prefer not doing this since the switch cases above don't check.
>
> Perhaps --diable-cocoa should be allowed on any platform.  You're
> right we don't have such checks now, but then it's hard to see
> downsides of doing them, so I'm quite ambivalent.

I'm vaguely negative about it because heading down that path increases
the number of tests and checks we end up performing before we do the
relatively straightforward thing of printing out a help message. (We
already do a pile of compiler/cpu tests early, which among other things
means 'configure --help' trashes config.log.)

"allow everything as an option and complain if it's not valid on this
machine" is at least easy to keep consistent.

-- PMM