Re: [Qemu-devel] [PATCH 1/4] console: a few cleanups

[Anthony Liguori]

On Jan 17, 2012 12:16 AM, "Stefan Weil" <address@hidden> wrote:
>
> Am 16.01.2012 23:36, schrieb Anthony Liguori:
>
>> We don't do anything with the list of registered DisplayState so get rid of it.
>> That's one less list to deal with down the road.
>>
>> Also pass DisplayState to the callbacks in DisplayState so users can avoid
>> global state references.
>>
>> Signed-off-by: Anthony Liguori<address@hidden>
>> ---
>>  console.c          |    9 +++------
>>  console.h          |    6 ++----
>>  hw/vmware_vga.c    |    4 ++--
>>  ui/sdl.c           |    4 ++--
>>  ui/spice-display.c |    4 ++--
>>  ui/vnc.c           |    4 ++--
>>  6 files changed, 13 insertions(+), 18 deletions(-)
>>
>
> Is checkpatch.pl buggy, or did you forget to run it?
>
> There are coding style issues at least in patch 1/4 and 2/4.

Please elaborate.

Regards,

Anthony Liguori

>
> Regards,
>
> Stefan Weil
>
>