[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] trace: [ŧracetool ] Do not precompute the e
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/6] trace: [ŧracetool ] Do not precompute the event number |
|
Date: |
Wed, 18 Jan 2012 10:34:51 +0000 |
On Wed, Jan 18, 2012 at 9:48 AM, Harsh Bora <address@hidden> wrote:
> On 01/11/2012 11:35 PM, Lluís Vilanova wrote:
>>
>> This would otherwise break event numbering when actually using the
>> "disable"
>> property.
>>
>
> IIUC, event numbering does include disabled events too, are you proposing
> not to include disabled events in event numbering ? That will affect
> interpreting event numbers while reading trace logs also.
I agree with Lluís. Here's how it worked in scripts/tracetool:
disabled events were processed with "nop" backend and therefore did
not increment the event counter in the "simple" backend.
Stefan
- [Qemu-devel] [PATCH 1/6] trace: [tracetool] Do not rebuild event list in backend code, Lluís Vilanova, 2012/01/11
- [Qemu-devel] [PATCH 2/6] trace: [tracetool] Simplify event line parsing, Lluís Vilanova, 2012/01/11
- [Qemu-devel] [PATCH 3/6] trace: [ŧracetool ] Do not precompute the event number, Lluís Vilanova, 2012/01/11
- [Qemu-devel] [PATCH 4/6] trace: [tracetool] Add support for event properties, Lluís Vilanova, 2012/01/11
- [Qemu-devel] [PATCH 5/6] trace: [tracetool] Process the "disable" event property, Lluís Vilanova, 2012/01/11
- [Qemu-devel] [PATCH 6/6] trace: [tracetool] Rewrite event argument parsing, Lluís Vilanova, 2012/01/11
- Re: [Qemu-devel] [PATCH 1/6] trace: [tracetool] Do not rebuild event list in backend code, Harsh Bora, 2012/01/18