Re: [Qemu-devel] [PATCH v7 07/10] ARM: exynos4210: MCT support.

[Evgeny Voevodin]

On 01/18/2012 03:46 PM, Peter Maydell wrote:
> On 16 January 2012 06:48, Evgeny Voevodin<address@hidden>  wrote:
> This doesn't compile on 32 bit hosts:
>
>    CC    arm-softmmu/exynos4210_mct.o
> cc1: warnings being treated as errors
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c: In
> function ‘exynos4210_gcomp_get_distance’:
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:485:
> error: integer constant is too large for ‘long’ type
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:487:
> error: integer constant is too large for ‘long’ type
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:490:
> error: integer constant is too large for ‘long’ type
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c: In
> function ‘exynos4210_gfrc_restart’:
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:507:
> error: integer constant is too large for ‘long’ type
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:508:
> error: integer constant is too large for ‘long’ type
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c: In
> function ‘exynos4210_gfrc_event’:
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:575:
> error: integer constant is too large for ‘long’ type
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:576:
> error: integer constant is too large for ‘long’ type
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c: In
> function ‘exynos4210_lfrc_update_count’:
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:599:
> error: integer constant is too large for ‘long’ type
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c: In
> function ‘exynos4210_ltick_recalc_count’:
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:843:
> error: integer constant is too large for ‘long’ type
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:845:
> error: integer constant is too large for ‘long’ type
> make[1]: *** [exynos4210_mct.o] Error 1
>
> These two 64 bit constants need a ULL suffix:
>
> > +#define MCT_GT_COUNTER_STEP     0x100000000
> > +#define MCT_LT_COUNTER_STEP     0x100000000
> -- PMM
Thanks. gcc 4.5 compiles it quietly on our systems, but 4.4 reports 
warnings. Will fix and provide v8 soon.

--
Kind regards,
Evgeny Voevodin,
Leading Software Engineer,
ASWG, Moscow R&D center, Samsung Electronics
e-mail: address@hidden