Re: [Qemu-devel] [PATCH v8 3/8] ARM: exynos4210: UART support

[Peter Maydell]

On 19 January 2012 08:31, Evgeny Voevodin <address@hidden> wrote:
> From: Maksim Kozlov <address@hidden>
> +static Exynos4210UartReg exynos4210_uart_regs[] = {
> +        {"ULCON"   , ULCON   , 0x00000000},
> +        {"UCON"    , UCON    , 0x00003000},
> +        {"UFCON"   , UFCON   , 0x00000000},
> +        {"UMCON"   , UMCON   , 0x00000000},
> +        {"UTRSTAT" , UTRSTAT , 0x00000006}, /* RO */
> +        {"UERSTAT" , UERSTAT , 0x00000000}, /* RO */
> +        {"UFSTAT"  , UFSTAT  , 0x00000000}, /* RO */
> +        {"UMSTAT"  , UMSTAT  , 0x00000000}, /* RO */
> +        {"UTXH"    , UTXH    , 0x5c5c5c5c}, /* WO, undefined reset value*/
> +        {"URXH"    , URXH    , 0x00000000}, /* RO */
> +        {"UBRDIV"  , UBRDIV  , 0x00000000},
> +        {"UFRACVAL", UFRACVAL, 0x00000000},
> +        {"UINTP"   , UINTP   , 0x00000000},
> +        {"UINTSP"  , UINTSP  , 0x00000000},
> +        {"UINTM"   , UINTM   , 0x00000000},
> +};

Indentation again.

> +static void exynos4210_uart_event(void *opaque, int event)
> +{
> +    /*
> +     * TODO: Implement this.
> +     *
> +     */
> +}

Implement this :-) You only need to handle CHR_EVENT_BREAK, so
it shouldn't be very hard.

-- PMM