Re: [Qemu-devel] [PATCH 02/14] target-sparc: Fix mixup of uint64 and uint64_t

[Blue Swirl]

On Mon, Jan 16, 2012 at 00:46, Andreas Färber <address@hidden> wrote:
> Commit 793a137a41ad4125011c7022cf16a1baa40a5ab6 (target-sparc:
> Implement BMASK/BSHUFFLE.) introduced a stray usage of softfloat uint64
> type.
>
> Use uint64_t instead.
>
> Signed-off-by: Andreas Färber <address@hidden>
> Cc: Richard Henderson <address@hidden>
> Cc: Blue Swirl <address@hidden>

Good catch,
Reviewed-by: Blue Swirl <address@hidden>

> ---
>  target-sparc/vis_helper.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-sparc/vis_helper.c b/target-sparc/vis_helper.c
> index a992c29..9d2edb0 100644
> --- a/target-sparc/vis_helper.c
> +++ b/target-sparc/vis_helper.c
> @@ -459,7 +459,7 @@ uint32_t helper_fpackfix(uint64_t gsr, uint64_t rs2)
>     return ret;
>  }
>
> -uint64 helper_bshuffle(uint64_t gsr, uint64_t src1, uint64_t src2)
> +uint64_t helper_bshuffle(uint64_t gsr, uint64_t src1, uint64_t src2)
>  {
>     union {
>         uint64_t ll[2];
> --
> 1.7.7
>