Re: [Qemu-devel] [PATCH] signrom: Rewrite as python script

[Markus Armbruster]

Jan Kiszka <address@hidden> writes:

> On 2012-01-24 16:22, Eric Blake wrote:
>> On 01/24/2012 01:53 AM, Jan Kiszka wrote:
>>> Now that we have a hard dependency on python anyway, we can replace the
>>> slow shell script to calculate the option ROM checksum with a fast AND
>>> portable python version. Tested both with python 2.7 and 3.1.
>>>
>>> Signed-off-by: Jan Kiszka <address@hidden>
>>> ---
>>>
>>> +++ b/scripts/signrom.py
>>> @@ -0,0 +1,40 @@
>>> +#
>>> +# Option ROM Signing utility
>>> +#
>>> +# Authors:
>>> +#  Jan Kiszka <address@hidden>
>>> +#
>>> +# This work is licensed under the terms of the GNU GPLv2.
>> 
>> Any reason you aren't using GPLv2+,
>
> Internal complications. :-/
>
>> 
>>> --- a/scripts/signrom.sh
>>> +++ /dev/null
>>> @@ -1,45 +0,0 @@
>>> -#!/bin/sh
>>> -
>>> -# Option ROM Signing utility
>>> -#
>>> -# This program is free software; you can redistribute it and/or modify
>>> -# it under the terms of the GNU General Public License as published by
>>> -# the Free Software Foundation; either version 2 of the License, or
>>> -# (at your option) any later version.
>> 
>> especially since you were replacing a more permissive license in the .sh
>> version?
>
> I'm writing new code, this is not a derivative.

Is it enough of an improvement to justify the licensing regression?