[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 22/28] virtio-serial: convert to QEMU Object Mod
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH 22/28] virtio-serial: convert to QEMU Object Model |
Date: |
Wed, 25 Jan 2012 01:29:50 +0530 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On (Tue) 24 Jan 2012 [13:33:14], Anthony Liguori wrote:
> diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
> index 982ffbf..edf54d7 100644
> --- a/hw/virtio-serial-bus.c
> +++ b/hw/virtio-serial-bus.c
> @@ -157,7 +157,7 @@ static void do_flush_queued_data(VirtIOSerialPort *port,
> VirtQueue *vq,
> ssize_t ret;
>
> buf_size = port->elem.out_sg[i].iov_len - port->iov_offset;
> - ret = info->have_data(port,
> + ret = vsc->have_data(port,
> port->elem.out_sg[i].iov_base
> + port->iov_offset,
> buf_size);
Would be nice if everything was re-indented.
> @@ -176,7 +176,7 @@ static void do_flush_queued_data(VirtIOSerialPort *port,
> VirtQueue *vq,
> * 1: chardevs can notify frondends
> * 2: the guest driver does not spin in these cases
> */
> - if (!info->is_console) {
> + if (vsc->is_console) {
> virtio_serial_throttle_port(port, true);
> }
> port->iov_idx = i;
This change is wrong, reverses the if condition. Was this done
manually or via a script? If the latter, it would be worthwhile to
check all the conversions.
> -void virtio_serial_port_qdev_register(VirtIOSerialPortInfo *info)
> +void virtio_serial_port_qdev_register(DeviceInfo *info)
Should the fn be renamed (replace qdev)?
Amit
- [Qemu-devel] [PATCH 16/28] i2c: rename i2c_slave -> I2CSlave, (continued)
- [Qemu-devel] [PATCH 16/28] i2c: rename i2c_slave -> I2CSlave, Anthony Liguori, 2012/01/24
- [Qemu-devel] [PATCH 18/28] hda-codec: convert to QEMU Object Model, Anthony Liguori, 2012/01/24
- [Qemu-devel] [PATCH 05/28] qdev: integrate with QEMU Object Model (v2), Anthony Liguori, 2012/01/24
- [Qemu-devel] [PATCH 03/28] pci: call reset unconditionally, Anthony Liguori, 2012/01/24
- [Qemu-devel] [PATCH 14/28] ccid: convert to QEMU Object Model, Anthony Liguori, 2012/01/24
- [Qemu-devel] [PATCH 10/28] qdev: add class_init to DeviceInfo, Anthony Liguori, 2012/01/24
- [Qemu-devel] [PATCH 13/28] usb: convert to QEMU Object Model, Anthony Liguori, 2012/01/24
- [Qemu-devel] [PATCH 22/28] virtio-serial: convert to QEMU Object Model, Anthony Liguori, 2012/01/24
- Re: [Qemu-devel] [PATCH 22/28] virtio-serial: convert to QEMU Object Model,
Amit Shah <=
- [Qemu-devel] [PATCH 15/28] ssi: convert to QEMU Object Model, Anthony Liguori, 2012/01/24
- Re: [Qemu-devel] [PATCH v3 0/28] qom: add QEMU Object Model type hierarchy to qdev, Peter Maydell, 2012/01/24
- Re: [Qemu-devel] [PATCH v3 0/28] qom: add QEMU Object Model type hierarchy to qdev, Blue Swirl, 2012/01/25
- Re: [Qemu-devel] [PATCH v3 0/28] qom: add QEMU Object Model type hierarchy to qdev, Anthony Liguori, 2012/01/27