[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 6/9] hw/vexpress.c: Factor out daughterboard-
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 6/9] hw/vexpress.c: Factor out daughterboard-specific initialization |
Date: |
Wed, 25 Jan 2012 19:53:26 +0000 |
On 25 January 2012 18:04, Andreas Färber <address@hidden> wrote:
> Am 24.01.2012 13:39, schrieb Peter Maydell:
>> +struct VEDBoardInfo {
>> + const target_phys_addr_t *motherboard_map;
>> + const target_phys_addr_t loader_start;
>
> const for a value type in a struct looks fishy...is it intentional and
> valid C99?
It's valid C99 (the effect would be that you can't assign to
boardinfo->loader_start and you can't do a structure copy
of a boardinfo either, but assigning to boardinfo->some_other_field
would be OK). However it's not what I actually meant to do;
this should just be "target_phys_addr_t loader_start;".
(The const target_phys_addr_t *motherboard_map; is of course OK.)
-- PMM
- [Qemu-devel] [PATCH v2 4/9] hw/vexpress.c: Make motherboard peripheral memory map table-driven, (continued)
- [Qemu-devel] [PATCH v2 4/9] hw/vexpress.c: Make motherboard peripheral memory map table-driven, Peter Maydell, 2012/01/24
- [Qemu-devel] [PATCH v2 5/9] hw/vexpress.c: Move secondary CPU boot code to SRAM, Peter Maydell, 2012/01/24
- [Qemu-devel] [PATCH v2 2/9] Add Cortex-A15 CPU definition, Peter Maydell, 2012/01/24
- [Qemu-devel] [PATCH v2 1/9] Add dummy implementation of generic timer cp15 registers, Peter Maydell, 2012/01/24
- [Qemu-devel] [PATCH v2 6/9] hw/vexpress.c: Factor out daughterboard-specific initialization, Peter Maydell, 2012/01/24
- [Qemu-devel] [PATCH v2 8/9] arm_boot: Pass base address of GIC CPU interface, not whole GIC, Peter Maydell, 2012/01/24