Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

[Markus Armbruster]

Gerhard Wiesinger <address@hidden> writes:

> Option ROM for network interface cards (NICs) can now explicitly disabled
> with romfile=disabled (or romfile=no or romfile=none) parameter.
> With hotplugable NICs (currently NE2000, PCNET) romfile=(empty) didn't work.
> This patch disables Option ROMs for iPXE for alls supported NICs
> (hotplugable and non hotplugable).

And now filenames "disabled", "no" and "none" don't work.

Any way to fix "romfile="?

> Examples with 2 NICs with disabled Option ROM (separated on different lines 
> for readabi$
> -device rtl8139,mac=1a:46:0b:ca:bc:7c,vlan=0,romfile=disabled
> -net tap,ifname=tap0,script=no,downscript=no,vlan=0
> -device pcnet,mac=1a:46:0b:ca:bc:7e,vlan=1,romfile=disabled
> -net tap,ifname=tap1,script=no,downscript=no,vlan=1
>
> Signed-off-by: Gerhard Wiesinger <address@hidden>

I_do_not_usually_do_this_but_I_make_an_exception_due_to_your_choice_of_illegibly_long_identifiers:
CODING_STYLE, please feed to scripts/checkpatch.pl and correct :)