[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] memory: fix return value on unassigned reads
|
From: |
Fabien Chouteau |
|
Subject: |
Re: [Qemu-devel] [PATCH] memory: fix return value on unassigned reads |
|
Date: |
Thu, 26 Jan 2012 12:31:37 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.24) Gecko/20111108 Lightning/1.0b2 Mnenhy/0.8.4 Thunderbird/3.1.16 |
On 26/01/2012 10:33, Avi Kivity wrote:
> The memory API returns -1 on unassigned reads, different from the original
> in exec.c, which returned zero.
Isn't this return value platform specific?
> This breaks grlib_uart; apparently some users depend on it.
>
> Fix by returning zero; however if reading from the uart is legal, then
> it should be modified to accept reads.
>
That's right, grlib_uart depends on it because I took the easy (lazy?)
way. I will send a patch to handle reads to UART's registers.
--
Fabien Chouteau