Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c

[Jan Kiszka]

On 2012-01-26 20:00, Anthony Liguori wrote:
> A long time ago, there was a grand plan to merge q35 chipset support.  The 
> start
> of that series was a refactoring of pc.c which split a bunch of the "common"
> functionality into a separate file that could be shared by the two.
> 
> But q35 never got merged and the refactoring, in retrospect, just made things
> worse.  Making things proper objects and using composition is the right way
> to share common devices.
> 
> By pulling these files back together, we can start to fix some of this mess.

There are surely things to clean up and improve, but a clear NACK for
the general direction.

It's undoubted that we need a more modern chipset than this ancient
PIIX3, rather sooner than later. And it is clear that there is a good
amount of generic functions in pc.c for building a PC, even a fairly
modern one. So we need a common lib for PC chipsets and would only
revert what you start here.

Please name what you do not like, and then we can fix that concretely.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux