Re: [Qemu-devel] [PATCH] optionroms: Silence intermediate file removal

[Andreas Färber]

Am 23.01.2012 19:34, schrieb Jan Kiszka:
> The build process of optionroms spits out an "rm ..." line. Moreover, it
> removes all .o files that can be handy for debugging purposes.
> 
> Disable automatic intermediate removal and only clean up the unneeded
> and large .img and .raw files.
> 
> Signed-off-by: Jan Kiszka <address@hidden>
> ---
>  pc-bios/optionrom/Makefile |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/pc-bios/optionrom/Makefile b/pc-bios/optionrom/Makefile
> index 51da288..3edde85 100644
> --- a/pc-bios/optionrom/Makefile
> +++ b/pc-bios/optionrom/Makefile
> @@ -16,14 +16,16 @@ QEMU_CFLAGS = $(CFLAGS)
>  
>  build-all: multiboot.bin linuxboot.bin
>  
> +.SECONDARY:
> +
>  %.img: %.o
>       $(call quiet-command,$(LD) -Ttext 0 -e _start -s -o $@ $<,"  Building 
> $(TARGET_DIR)$@")
>  
>  %.raw: %.img
> -     $(call quiet-command,$(OBJCOPY) -O binary -j .text $< $@,"  Building 
> $(TARGET_DIR)$@")
> +     $(call quiet-command,$(OBJCOPY) -O binary -j .text $< $@; rm -f $<,"  
> Building $(TARGET_DIR)$@")
>  
>  %.bin: %.raw
> -     $(call quiet-command,$(SHELL) $(SRC_PATH)/scripts/signrom.sh $< $@,"  
> Signing $(TARGET_DIR)$@")
> +     $(call quiet-command,$(SHELL) $(SRC_PATH)/scripts/signrom.sh $< $@; rm 
> -f $<,"  Signing $(TARGET_DIR)$@")
>  
>  clean:
>       rm -f *.o *.d *.raw *.img *.bin *~

It's possible that objcopy or a shell script fails. In that case,
&& rm -f $<
or a second output-suppressed Makefile line might be a better than
; rm -f $<

Stefan's comment on .SECONDARY seconded. :)

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg