Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

[Gerhard Wiesinger]

On Thu, 26 Jan 2012, Markus Armbruster wrote:

> Gerd Hoffmann <address@hidden> writes:
>
> > On 01/26/12 08:45, Markus Armbruster wrote:
> > > Gerhard Wiesinger <address@hidden> writes:
> > >
> > > > Option ROM for network interface cards (NICs) can now explicitly disabled
> > > > with romfile=disabled (or romfile=no or romfile=none) parameter.
> > > > With hotplugable NICs (currently NE2000, PCNET) romfile=(empty) didn't work.
> > > > This patch disables Option ROMs for iPXE for alls supported NICs
> > > > (hotplugable and non hotplugable).
> > >
> > > And now filenames "disabled", "no" and "none" don't work.
> > >
> > > Any way to fix "romfile="?
> >
> > Sure.
>
> This patch looks much better.  Gerhard does it solve your problem?
> Gerd, you might want to repost it in its own thread, as maintainers can
> easily miss patches buried deep in replies.

Can confirm this patch works well in all tried combinations.

3 Comments:
1.) NOK?: 2 NICs installed, no bootindex specified: Tries to boot only 
from one NIC, then from C: (one NIC has index first, second one has last 
index)
-boot order=nca,menu=on
-device rtl8139,mac=1a:46:0b:ca:bc:7c,vlan=0 -net 
tap,ifname=tap0,script=no,downscript=no,vlan=0
 -device pcnet,mac=1a:46:0b:ca:bc:7e,vlan=1 -net 
tap,ifname=tap1,script=no,downscript=no,vlan=1
I would expect to try to boot from both NICs
1. iPXE (PCI 00:04:0)
...
8. iPXE (PCI 00:05:0)

2.) OK: 2 NICs installed, bootindex specified: Tries to boot from first 
and second NIC
-boot order=nca,menu=on
-device rtl8139,mac=1a:46:0b:ca:bc:7c,vlan=0,bootindex=1 -net 
tap,ifname=tap0,script=no,downscript=no,vlan=0
-device pcnet,mac=1a:46:0b:ca:bc:7e,vlan=1,bootindex=2 -net 
tap,ifname=tap1,script=no,downscript=no,vlan=1
1. iPXE (PCI 00:04:0)
2. iPXE (PCI 00:05:0)
...

3.) NOK: 2 NICs installed, bootindex specified in reverse order: Tries to 
boot from 7e NIC and reboots ...
-boot order=nca,menu=on
-device rtl8139,mac=1a:46:0b:ca:bc:7c,vlan=0,bootindex=2 -net 
tap,ifname=tap0,script=no,downscript=no,vlan=0
-device pcnet,mac=1a:46:0b:ca:bc:7e,vlan=1,bootindex=1 -net 
tap,ifname=tap1,script=no,downscript=no,vlan=1
1. iPXE (PCI 00:05:0)
2. iPXE (PCI 00:04:0)
...

Ciao,
Gerhard

--
http://www.wiesinger.com/