[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC 5/9] exec: fix check_watchpoint exiting cpu_loop
From: |
Max Filippov |
Subject: |
[Qemu-devel] [RFC 5/9] exec: fix check_watchpoint exiting cpu_loop |
Date: |
Sun, 29 Jan 2012 06:19:27 +0400 |
In case of BP_STOP_BEFORE_ACCESS watchpoint check_watchpoint intends to
signal EXCP_DEBUG exception on exit from cpu loop, but later overwrites
exception code by the cpu_resume_from_signal call.
Use cpu_loop_exit with BP_STOP_BEFORE_ACCESS watchpoints.
Signed-off-by: Max Filippov <address@hidden>
---
exec.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/exec.c b/exec.c
index 0e93e0e..bc6c185 100644
--- a/exec.c
+++ b/exec.c
@@ -3247,11 +3247,12 @@ static void check_watchpoint(int offset, int len_mask,
int flags)
tb_phys_invalidate(tb, -1);
if (wp->flags & BP_STOP_BEFORE_ACCESS) {
env->exception_index = EXCP_DEBUG;
+ cpu_loop_exit(env);
} else {
cpu_get_tb_cpu_state(env, &pc, &cs_base, &cpu_flags);
tb_gen_code(env, pc, cs_base, cpu_flags, 1);
+ cpu_resume_from_signal(env, NULL);
}
- cpu_resume_from_signal(env, NULL);
}
} else {
wp->flags &= ~BP_WATCHPOINT_HIT;
--
1.7.7.6
- [Qemu-devel] [RFC 0/9] target-xtensa: implement debug option, Max Filippov, 2012/01/28
- [Qemu-devel] [RFC 1/9] target-xtensa: add DEBUGCAUSE SR and configuration, Max Filippov, 2012/01/28
- [Qemu-devel] [RFC 2/9] target-xtensa: implement instruction breakpoints, Max Filippov, 2012/01/28
- [Qemu-devel] [RFC 3/9] target-xtensa: add ICOUNT SR and debug exception, Max Filippov, 2012/01/28
- [Qemu-devel] [RFC 5/9] exec: fix check_watchpoint exiting cpu_loop,
Max Filippov <=
- [Qemu-devel] [RFC 6/9] exec: let cpu_watchpoint_insert accept larger watchpoints, Max Filippov, 2012/01/28
- [Qemu-devel] [RFC 4/9] exec: add missing breaks to the watch_mem_write, Max Filippov, 2012/01/28
- [Qemu-devel] [RFC 8/9] target-xtensa: add DEBUG_SECTION to overlay tool, Max Filippov, 2012/01/28
- [Qemu-devel] [RFC 7/9] target-xtensa: add DBREAK data breakpoints, Max Filippov, 2012/01/28
- [Qemu-devel] [RFC 9/9] target-xtensa: add breakpoint tests, Max Filippov, 2012/01/28