[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 6/7] pcspk: Convert to qdev
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH v3 6/7] pcspk: Convert to qdev |
Date: |
Wed, 01 Feb 2012 10:18:41 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-02-01 08:29, Paolo Bonzini wrote:
> On 01/31/2012 09:49 PM, Anthony Liguori wrote:
>>>
>>> + DEFINE_PROP_HEX32("iobase", PCSpkState, iobase, -1),
>>> + DEFINE_PROP_PTR("pit", PCSpkState, pit),
>>
>> Please don't introduce a pointer property here. They cannot be used in
>> a meaningful way in qdev. Why not register a link<TYPE_PIT> in
>> instance_init?
>
> I'm going to clean this up, you can leave the PTR for now.
OK, will then ship v4 with this property still in place and count on you.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux