Re: [Qemu-devel] [PATCH 2/2] Run pod2man with --utf8 option to enable utf8 in manpages

[Michael Tokarev]

On 02.02.2012 18:32, Peter Maydell wrote:
> On 2 February 2012 14:16, Michael Tokarev <address@hidden> wrote:
>> +POD2MAN = pod2man --utf8
>>  qemu.1: qemu-doc.texi qemu-options.texi qemu-monitor.texi
>>        $(call quiet-command, \
>>          perl -Ww -- $(SRC_PATH)/scripts/texi2pod.pl $< qemu.pod && \
>> -         pod2man --section=1 --center=" " --release=" " qemu.pod > $@, \
>> +         $(POD2MAN) --section=1 --center=" " --release=" " qemu.pod > $@, \
[]
> So why does '--utf8' qualify as a common option that we specify just once in
> the POD2MAN variable, but --center=" " and --release=" " don't?

Maybe --release is ok here, but I don't think --center is.  Because, well,
--release is the same for every manpage (it corresponds to qemu release
number of something of this kind), but --center may actually be used one
day with different values for different manpages.

Besides, this is a task for another patch, since this one "only" thing
this patch does is addresses the --utf8 issue.  Maybe it is so trivial
that adding --release here actually does fit nicely too.  I don't care
either way, what matters is to fix the mojibake which currently exists
in qemu.1 manpage.

> Maybe we could reduce the duplication here with a makefile function?

I'm not sure it is worth the extra complexity.  The way it is now is
more visible than a function.  Just IMHO anyway.

Thanks,

/mjt