[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 13/16] qdev: fix off-by-one
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 13/16] qdev: fix off-by-one |
Date: |
Thu, 2 Feb 2012 17:45:39 +0100 |
Integer properties did not work.
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/qdev-properties.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 7efcc78..30abae2 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
@@ -151,7 +151,7 @@ static void set_int8(Object *obj, Visitor *v, void *opaque,
error_propagate(errp, local_err);
return;
}
- if (value > prop->info->min && value <= prop->info->max) {
+ if (value >= prop->info->min && value <= prop->info->max) {
*ptr = value;
} else {
error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE,
@@ -259,7 +259,7 @@ static void set_int16(Object *obj, Visitor *v, void *opaque,
error_propagate(errp, local_err);
return;
}
- if (value > prop->info->min && value <= prop->info->max) {
+ if (value >= prop->info->min && value <= prop->info->max) {
*ptr = value;
} else {
error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE,
@@ -333,7 +333,7 @@ static void set_int32(Object *obj, Visitor *v, void *opaque,
error_propagate(errp, local_err);
return;
}
- if (value > prop->info->min && value <= prop->info->max) {
+ if (value >= prop->info->min && value <= prop->info->max) {
*ptr = value;
} else {
error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE,
--
1.7.7.6
- Re: [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address property accept an integer, (continued)
- Re: [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address property accept an integer, Anthony Liguori, 2012/02/02
- Re: [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address property accept an integer, Paolo Bonzini, 2012/02/02
- Re: [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address property accept an integer, Anthony Liguori, 2012/02/03
- Re: [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address property accept an integer, Paolo Bonzini, 2012/02/03
- Re: [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address property accept an integer, Paolo Bonzini, 2012/02/03
- Re: [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address property accept an integer, Anthony Liguori, 2012/02/03
- Re: [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address property accept an integer, Paolo Bonzini, 2012/02/04
- Re: [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address property accept an integer, Paolo Bonzini, 2012/02/04
[Qemu-devel] [PATCH 12/16] qdev: let QOM free properties, Paolo Bonzini, 2012/02/02
[Qemu-devel] [PATCH 08/16] qdev: remove parse method for string properties, Paolo Bonzini, 2012/02/02
[Qemu-devel] [PATCH 13/16] qdev: fix off-by-one,
Paolo Bonzini <=
[Qemu-devel] [PATCH 11/16] qdev: remove parse/print methods for pointer properties, Paolo Bonzini, 2012/02/02
[Qemu-devel] [PATCH 14/16] qdev: access properties via QOM, Paolo Bonzini, 2012/02/02
[Qemu-devel] [PATCH 16/16] qdev: initialize properties via QOM, Paolo Bonzini, 2012/02/02
[Qemu-devel] [PATCH 15/16] qdev: inline qdev_prop_set into qdev_prop_set_ptr, Paolo Bonzini, 2012/02/02