Re: [Qemu-devel] [PATCH 04/16] qom: add QObject-based property get/set wrappers

[Andreas Färber]

Am 02.02.2012 20:06, schrieb Anthony Liguori:
> On 02/02/2012 10:45 AM, Paolo Bonzini wrote:
>> Move the creation of QmpInputVisitor and QmpOutputVisitor from
>> qmp.c to qom/object.c, since it's the only practical way to access
>> object properties.
>>
>> Signed-off-by: Paolo Bonzini<address@hidden>
>> ---
>>   include/qemu/object.h |   24 ++++++++++++++++++++++++
>>   qmp.c                 |   17 ++---------------
>>   qom/object.c          |   29 +++++++++++++++++++++++++++++
>>   3 files changed, 55 insertions(+), 15 deletions(-)
> 
> I don't want object.h to have a dependency on QObject.  We need to phase
> out QObject.

We did get that dependency though by your move of the property code to
object.c. As you will see shortly, we now need qobject-obj-y and
qapi-obj-y plus some stubs to make the user emulators compile with QOM.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg