qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address pro


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 10/16] qdev: make the non-legacy pci address property accept an integer
Date: Sat, 04 Feb 2012 01:21:04 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0

On 02/03/2012 03:14 PM, Anthony Liguori wrote:


Nope, the legacy property still keeps the dd.f format. This is only
for QOM (and
internal use by qdev).

Ah, I forgot we duplicate the properties here.

Since there is now a programmatic mapping between legacy properties
types and non-legacy property types, could we remove the legacy
properties that now have well behaved types and add some code to
device_add to maintain compatibility?

I'm not sure... we would trade removal of an ugly concept (the legacy properties) with addition of a layering violation (poking into the DeviceState subclasses).

We could hide them in qom-list/qom-get, but I'm not sure this would buy us anything, either.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]