Re: [Qemu-devel] [PATCH] memory-region: Report if region is read-only on info mtree

[Blue Swirl]

On Fri, Feb 3, 2012 at 12:02, Jan Kiszka <address@hidden> wrote:
> Helpful to understand guest configurations of things like the i440FX's
> PAM.
>
> Signed-off-by: Jan Kiszka <address@hidden>
> ---
>  memory.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/memory.c b/memory.c
> index ee4c98a..ea4adda 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -1608,23 +1608,25 @@ static void mtree_print_mr(fprintf_function 
> mon_printf, void *f,
>             ml->printed = false;
>             QTAILQ_INSERT_TAIL(alias_print_queue, ml, queue);
>         }
> -        mon_printf(f, TARGET_FMT_plx "-" TARGET_FMT_plx " (prio %d): alias 
> %s @%s "
> +        mon_printf(f, TARGET_FMT_plx "-" TARGET_FMT_plx " (prio %d, %s): 
> alias %s @%s "
>                    TARGET_FMT_plx "-" TARGET_FMT_plx "\n",
>                    base + mr->addr,
>                    base + mr->addr
>                    + (target_phys_addr_t)int128_get64(mr->size) - 1,
>                    mr->priority,
> +                   mr->readonly ? "RO" : "RW",

I think the reserved regions which are unreadable and unwritable
should be shown as well. Then the output should be a combination of
'R', 'W' or neither ('-').

>                    mr->name,
>                    mr->alias->name,
>                    mr->alias_offset,
>                    mr->alias_offset
>                    + (target_phys_addr_t)int128_get64(mr->size) - 1);
>     } else {
> -        mon_printf(f, TARGET_FMT_plx "-" TARGET_FMT_plx " (prio %d): %s\n",
> +        mon_printf(f, TARGET_FMT_plx "-" TARGET_FMT_plx " (prio %d, %s): 
> %s\n",
>                    base + mr->addr,
>                    base + mr->addr
>                    + (target_phys_addr_t)int128_get64(mr->size) - 1,
>                    mr->priority,
> +                   mr->readonly ? "RO" : "RW",
>                    mr->name);
>     }
>
> --
> 1.7.3.4