qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 15/27] qdev: remove parse method for string p


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH v2 15/27] qdev: remove parse method for string properties
Date: Mon, 06 Feb 2012 08:31:31 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110922 Lightning/1.0b2 Thunderbird/3.1.15

On 02/04/2012 02:02 AM, Paolo Bonzini wrote:
We need the print method to put double quotes, but parsing is not special.

Signed-off-by: Paolo Bonzini<address@hidden>

Reviewed-by: Anthony Liguori <address@hidden>

Regards,

Anthony Liguori

---
  hw/qdev-properties.c |   11 -----------
  1 files changed, 0 insertions(+), 11 deletions(-)

diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 5e19ec8..1fc77b5 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
@@ -510,16 +510,6 @@ PropertyInfo qdev_prop_hex64 = {

  /* --- string --- */

-static int parse_string(DeviceState *dev, Property *prop, const char *str)
-{
-    char **ptr = qdev_get_prop_ptr(dev, prop);
-
-    if (*ptr)
-        g_free(*ptr);
-    *ptr = g_strdup(str);
-    return 0;
-}
-
  static void free_string(DeviceState *dev, Property *prop)
  {
      g_free(*(char **)qdev_get_prop_ptr(dev, prop));
@@ -581,7 +571,6 @@ PropertyInfo qdev_prop_string = {
      .name  = "string",
      .type  = PROP_TYPE_STRING,
      .size  = sizeof(char*),
-    .parse = parse_string,
      .print = print_string,
      .free  = free_string,
      .get   = get_string,




reply via email to

[Prev in Thread] Current Thread [Next in Thread]