[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC Patch 2/7]Qemu: Error classes for file reopen and
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RFC Patch 2/7]Qemu: Error classes for file reopen and data sync failure |
Date: |
Tue, 7 Feb 2012 07:56:34 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Feb 01, 2012 at 08:36:28AM +0530, Supriya Kannery wrote:
> Index: qemu/qerror.c
> ===================================================================
> --- qemu.orig/qerror.c
> +++ qemu/qerror.c
> @@ -108,6 +108,14 @@ static const QErrorStringTable qerror_ta
> .desc = "Device '%(device)' has multiple child busses",
> },
> {
> + .error_fmt = QERR_DATA_SYNC_FAILED,
> + .desc = "Syncing of data failed for device '%(device)'",
> + },
> + {
> + .error_fmt = QERR_REOPEN_FILE_FAILED,
> + .desc = "Could not reopen '%(filename)'",
> + },
The comment in qerror.c says:
"Please keep the entries in alphabetical order.
Use scripts/check-qerror.sh to check."
> + {
> .error_fmt = QERR_DEVICE_NO_BUS,
> .desc = "Device '%(device)' has no child bus",
> },
> Index: qemu/qerror.h
> ===================================================================
> --- qemu.orig/qerror.h
> +++ qemu/qerror.h
> @@ -117,6 +117,9 @@ QError *qobject_to_qerror(const QObject
> #define QERR_DEVICE_NOT_FOUND \
> "{ 'class': 'DeviceNotFound', 'data': { 'device': %s } }"
>
> +#define QERR_DATA_SYNC_FAILED \
> + "{ 'class': 'DataSyncFailed', 'data': { 'device': %s } }"
> +
Same here:
/*
* QError class list
* Please keep the definitions in alphabetical order.
* Use scripts/check-qerror.sh to check.
*/
- Re: [Qemu-devel] [RFC Patch 2/7]Qemu: Error classes for file reopen and data sync failure,
Stefan Hajnoczi <=