qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/3] vmmouse: replace PROP_PTR property with gpi


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 3/3] vmmouse: replace PROP_PTR property with gpio pin to i8042
Date: Tue, 07 Feb 2012 13:54:11 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0

On 02/07/2012 01:39 PM, Juan Quintela wrote:
>            vmmouse = isa_try_create(isa_bus, "vmmouse");
>  +        qdev_init_nofail(&vmmouse->qdev);
>  +        qdev_connect_gpio_out(DEVICE(vmmouse), 0,
>  +                              qdev_get_gpio_in(DEVICE(i8042), 0));
Are you sue that vmmouse is always non-NULL?  My understanding is that
all callers check if is_try_create() return NULL.

Could you clarify?

No, I couldn't. :)  You're right.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]