[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 05/19] vl.c: Error locations for options using add_d
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 05/19] vl.c: Error locations for options using add_device_config() |
Date: |
Tue, 7 Feb 2012 15:09:12 +0100 |
These are -bt, -serial, -virtcon, -parallel, -debugcon, -usbdevice.
Improves messages emitted via proper error reporting interfaces. For
instance:
$ qemu-system-x86_64 -nodefaults -S -usb -usbdevice net:vlan=xxx
qemu-system-x86_64: Parameter 'vlan' expects a number
becomes:
qemu-system-x86_64: -usbdevice net:vlan=xxx: Parameter 'vlan' expects a
number
Many more remain unimproved, because they're fprintf()ed. The next
few commits will take care of that.
Signed-off-by: Markus Armbruster <address@hidden>
---
vl.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index 2d464cf..e252a9d 100644
--- a/vl.c
+++ b/vl.c
@@ -1859,6 +1859,7 @@ struct device_config {
DEV_DEBUGCON, /* -debugcon */
} type;
const char *cmdline;
+ Location loc;
QTAILQ_ENTRY(device_config) next;
};
QTAILQ_HEAD(, device_config) device_configs =
QTAILQ_HEAD_INITIALIZER(device_configs);
@@ -1870,6 +1871,7 @@ static void add_device_config(int type, const char
*cmdline)
conf = g_malloc0(sizeof(*conf));
conf->type = type;
conf->cmdline = cmdline;
+ loc_save(&conf->loc);
QTAILQ_INSERT_TAIL(&device_configs, conf, next);
}
@@ -1881,7 +1883,9 @@ static int foreach_device_config(int type, int
(*func)(const char *cmdline))
QTAILQ_FOREACH(conf, &device_configs, next) {
if (conf->type != type)
continue;
+ loc_push_restore(&conf->loc);
rc = func(conf->cmdline);
+ loc_pop(&conf->loc);
if (0 != rc)
return rc;
}
--
1.7.6.5
- [Qemu-devel] [PATCH 00/19] Fix and improve chardev open error messages, Markus Armbruster, 2012/02/07
- [Qemu-devel] [PATCH 01/19] Revert "qemu-char: Print strerror message on failure" and deps, Markus Armbruster, 2012/02/07
- [Qemu-devel] [PATCH 05/19] vl.c: Error locations for options using add_device_config(),
Markus Armbruster <=
- [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part, Markus Armbruster, 2012/02/07
- Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part, Anthony Liguori, 2012/02/07
- Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part, Markus Armbruster, 2012/02/09
- Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part, Markus Armbruster, 2012/02/14
- Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part, Anthony Liguori, 2012/02/14
- Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part, Markus Armbruster, 2012/02/15
- Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part, Anthony Liguori, 2012/02/22
- Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part, Markus Armbruster, 2012/02/23
[Qemu-devel] [PATCH 16/19] spice-qemu-char: Chardev open error reporting, spicevmc part, Markus Armbruster, 2012/02/07
[Qemu-devel] [PATCH 12/19] qemu-char: Chardev open error reporting, tty part, Markus Armbruster, 2012/02/07