Re: [Qemu-devel] [PATCH v4 08/15] qmp: add block_job_cancel command

[Stefan Hajnoczi]

On Fri, Jan 20, 2012 at 7:55 PM, Eric Blake <address@hidden> wrote:
> On 01/20/2012 01:30 AM, Kevin Wolf wrote:
>>> Is there any policy on _ vs - in command names?  It seems awkward to
>>> have block_job_cancel but query-block-jobs.
>>
>> block_job_cancel is HMP, whereas query-block-jobs is a QMP command. QMP
>> uses - consistently. Not sure if HMP is consistent, but it tends to use _.
>
> OK, on RHEL 6.2, 'help' on HMP includes help for block_job_cancel, and
> '{"execute":"query-commands"}' on QMP includes
> {"name":"block_job_cancel"}, with underscores in both locations.  So if
> your new QMP command is block-job-cancel, you've met the goal of having
> a different spelling from the RHEL backport of the earlier semantics.
> And if you stuck with underscores, then it's RHEL's problem to solve :)

Hi Eric,
qemu.git/master has "query-block-jobs" with all other
streaming/blockjob commands using underscores.  I suspect this is
identical to RHEL 6.2.

Stefan