Re: [Qemu-devel] [PATCH RFC v3 08/21] target-arm: Move CPU feature flags out of CPUState

[Peter Maydell]

On 3 February 2012 02:59, Andreas Färber <address@hidden> wrote:
> +static void sa11xx_class_init(ARMCPUClass *k, const ARMCPUInfo *info)
> +{
> +    set_class_feature(k, ARM_FEATURE_STRONGARM);
> +}

>  static const ARMCPUInfo arm_cpus[] = {
>     {
>         .name = "arm926",
>         .id = 0x41069265,
> +        .features = ARM_FEATURE(V5) |
> +                    ARM_FEATURE(VFP),
>     },

>     {
>         .name = "sa1100",
>         .id = 0x4401A11B,
> +        .class_init = sa11xx_class_init,
>     },

So why are we handling some of these feature bits by setting them
in .features, and some of them via a .class_init which sets the
feature bit?

-- PMM