Re: [Qemu-devel] [PATCH RFC v3 13/21] target-arm: Store JTAG_ID in ARMCPUClass

[Andreas Färber]

Am 07.02.2012 18:47, schrieb Peter Maydell:
> On 3 February 2012 02:59, Andreas Färber <address@hidden> wrote:
>> That way we can remove some more CPUID cases without losing info.
>>
>> Signed-off-by: Andreas Färber <address@hidden>
>> Cc: Peter Maydell <address@hidden>
>> Cc: Andrzej Zaborowski <address@hidden>
>> ---
>>  target-arm/cpu-core.h |    1 +
>>  target-arm/cpu.c      |    2 ++
>>  target-arm/cpu.h      |    5 -----
>>  target-arm/helper.c   |    8 --------
>>  4 files changed, 3 insertions(+), 13 deletions(-)
>>
>> diff --git a/target-arm/cpu-core.h b/target-arm/cpu-core.h
>> index 3e7dfae..eac1a03 100644
>> --- a/target-arm/cpu-core.h
>> +++ b/target-arm/cpu-core.h
>> @@ -48,6 +48,7 @@ typedef struct ARMCPUClass {
>>         uint32_t c0_c2[8];
>>         uint32_t c1_sys;
>>     } cp15;
>> +    uint64_t jtag_id;
> 
> If we're not using this anywhere we should just not have it.

Andrzej will have had his reasons to put it in the code. This series
just moves code around so I don't want to remove it without his ack. I
cc'ed him in the hopes of getting an explanation. :)

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg