Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC64: Add support for ldbrx and stdbrx instructions

[Thomas Huth]

Am Wed, 8 Feb 2012 21:48:40 +1100
schrieb David Gibson <address@hidden>:

> On Wed, Feb 08, 2012 at 10:54:21AM +0400, malc wrote:
> > On Wed, 8 Feb 2012, David Gibson wrote:
> > 
> > > From: Thomas Huth <address@hidden>
> > > 
> > > These instructions for loading and storing byte-swapped 64-bit values have
> > > been introduced in PowerISA 2.06.
> > > 
> > > Signed-off-by: Thomas Huth <address@hidden>
> > > ---
> > >  target-ppc/translate.c |   30 ++++++++++++++++++++++++++++++
> > >  1 files changed, 30 insertions(+), 0 deletions(-)
> > 
> > I seem to recall that POWER5 machine i had access to didn't have 
> > ld/stdbrx while CBE did have it (or was it the other way around?)
> > so question is - is PPC_64B sufficient?
> 
> Ah, I think it's not.  I think I spotted that before, but then forgot
> about it.  Thanks for the reminder.

Maybe it's a better idea to use PPC_64BX here? ... but that flag seems
to be missing in POWERPC_INSNS_POWER7... David, could PPC_64BX also be
included in that flag list?

 Thomas