[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/6] balloon: Refactor kvm sync mmu check
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 4/6] balloon: Refactor kvm sync mmu check |
Date: |
Wed, 8 Feb 2012 18:30:38 -0200 |
qmp_query_balloon() and qmp_balloon() perform the same check, move it
to check_kvm_sync_mmu().
Signed-off-by: Luiz Capitulino <address@hidden>
---
balloon.c | 15 +++++++++++----
1 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/balloon.c b/balloon.c
index b32b487..d340ae3 100644
--- a/balloon.c
+++ b/balloon.c
@@ -80,12 +80,20 @@ static int qemu_balloon_info(BalloonInfo *info)
return 1;
}
+static bool check_kvm_sync_mmu(Error **errp)
+{
+ if (kvm_enabled() && !kvm_has_sync_mmu()) {
+ error_set(errp, QERR_KVM_MISSING_CAP, "synchronous MMU", "balloon");
+ return false;
+ }
+ return true;
+}
+
BalloonInfo *qmp_query_balloon(Error **errp)
{
BalloonInfo *info;
- if (kvm_enabled() && !kvm_has_sync_mmu()) {
- error_set(errp, QERR_KVM_MISSING_CAP, "synchronous MMU", "balloon");
+ if (!check_kvm_sync_mmu(errp)) {
return NULL;
}
@@ -102,8 +110,7 @@ BalloonInfo *qmp_query_balloon(Error **errp)
void qmp_balloon(int64_t value, Error **errp)
{
- if (kvm_enabled() && !kvm_has_sync_mmu()) {
- error_set(errp, QERR_KVM_MISSING_CAP, "synchronous MMU", "balloon");
+ if (!check_kvm_sync_mmu(errp)) {
return;
}
--
1.7.9.111.gf3fb0.dirty
- [Qemu-devel] [PATCH 0/6] QMP: add balloon-get-memory-stats command, Luiz Capitulino, 2012/02/08
- [Qemu-devel] [PATCH 2/6] balloon: Drop unused include, Luiz Capitulino, 2012/02/08
- [Qemu-devel] [PATCH 1/6] balloon: qmp_balloon(): Use error_set(), Luiz Capitulino, 2012/02/08
- [Qemu-devel] [PATCH 4/6] balloon: Refactor kvm sync mmu check,
Luiz Capitulino <=
- [Qemu-devel] [PATCH 3/6] balloon: Rename QEMUBalloonStatus to QEMUBalloonInfo, Luiz Capitulino, 2012/02/08
- [Qemu-devel] [PATCH 5/6] balloon: Drop old stats interface, Luiz Capitulino, 2012/02/08
- [Qemu-devel] [PATCH 6/6] qmp: add balloon-get-memory-stats & event, Luiz Capitulino, 2012/02/08
- Re: [Qemu-devel] [PATCH 6/6] qmp: add balloon-get-memory-stats & event, Luiz Capitulino, 2012/02/17