Re: [Qemu-devel] [PATCH 00/10] Remove AddressSpaceOps

[Richard Henderson]

On 02/08/2012 07:27 AM, Avi Kivity wrote:
> This patchset makes the memory core (memory.c) talk to the backend (in exec.c)
> via a MemoryListener instead of named functions.
> 
> While the motivation for this is to simplify the memory core, it also enables
> optimizing accelerators some more (by having a tcg MemoryListener to do tcg
> specific core) and allows unit testing of memory.c (by adding a testing
> MemoryListener and seeing what it outputs as various inputs are fed into the
> core).
> 
> Avi Kivity (10):
>   ioport: change portio_list not to use memory_region_set_offset()
>   memory: remove memory_region_set_offset()
>   memory: add shorthand for invoking a callback on all listeners
>   memory: switch memory listeners to a QTAILQ
>   memory: code motion: move MEMORY_LISTENER_CALL()
>   memory: move ioeventfd ops to MemoryListener
>   memory: add a readonly attribute to MemoryRegionSection
>   memory: don't pass ->readable attribute to
>     cpu_register_physical_memory_log
>   memory: use a MemoryListener for core memory map updates too
>   memory: drop AddressSpaceOps

Looks good.

Reviewed-by: Richard Henderson <address@hidden>


r~