[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC][PATCH 13/16 v6] support to set dumping speed
From: |
Wen Congyang |
Subject: |
[Qemu-devel] [RFC][PATCH 13/16 v6] support to set dumping speed |
Date: |
Thu, 09 Feb 2012 11:32:06 +0800 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100413 Fedora/3.0.4-2.fc13 Thunderbird/3.0.4 |
Add API to allow the user to control dumping speed
Signed-off-by: Wen Congyang <address@hidden>
---
dump.c | 12 ++++++++++++
hmp-commands.hx | 15 +++++++++++++++
hmp.c | 6 ++++++
hmp.h | 1 +
qapi-schema.json | 15 +++++++++++++++
qmp-commands.hx | 22 ++++++++++++++++++++++
6 files changed, 71 insertions(+), 0 deletions(-)
diff --git a/dump.c b/dump.c
index cea4c8c..9f0aceb 100644
--- a/dump.c
+++ b/dump.c
@@ -86,6 +86,7 @@ typedef struct DumpState {
} DumpState;
#define DEFAULT_THROTTLE (32 << 20) /* Default dump speed throttling */
+#define MIN_THROTTLE (1 << 10) /* Miniumum dump speed */
static DumpState *dump_get_current(void)
{
@@ -722,3 +723,14 @@ void qmp_dump_cancel(Error **errp)
dump_cleanup(s);
return;
}
+
+void qmp_dump_set_speed(int64_t value, Error **errp)
+{
+ DumpState *s = dump_get_current();
+
+ if (value < MIN_THROTTLE) {
+ value = MIN_THROTTLE;
+ }
+ s->bandwidth = value;
+ return;
+}
diff --git a/hmp-commands.hx b/hmp-commands.hx
index d0f3485..407bd06 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -897,6 +897,21 @@ Cancel the current VM dumping.
ETEXI
{
+ .name = "dump_set_speed",
+ .args_type = "value:o",
+ .params = "value",
+ .help = "set maximum speed (in bytes) for dumping. "
+ "Defaults to MB if no size suffix is specified, ie. B/K/M/G/T",
+ .mhandler.cmd = hmp_dump_set_speed,
+ },
+
+STEXI
address@hidden dump_set_speed @var{value}
address@hidden dump_set_speed
+Set maximum speed to @var{value} (in bytes) for dumping.
+ETEXI
+
+ {
.name = "snapshot_blkdev",
.args_type = "device:B,snapshot-file:s?,format:s?",
.params = "device [new-image-file] [format]",
diff --git a/hmp.c b/hmp.c
index 3865032..de70690 100644
--- a/hmp.c
+++ b/hmp.c
@@ -866,3 +866,9 @@ void hmp_dump_cancel(Monitor *mon, const QDict *qdict)
{
qmp_dump_cancel(NULL);
}
+
+void hmp_dump_set_speed(Monitor *mon, const QDict *qdict)
+{
+ int64_t value = qdict_get_int(qdict, "value");
+ qmp_dump_set_speed(value, NULL);
+}
diff --git a/hmp.h b/hmp.h
index c712f63..8de4aff 100644
--- a/hmp.h
+++ b/hmp.h
@@ -60,5 +60,6 @@ void hmp_block_job_set_speed(Monitor *mon, const QDict
*qdict);
void hmp_block_job_cancel(Monitor *mon, const QDict *qdict);
void hmp_dump(Monitor *mon, const QDict *qdict);
void hmp_dump_cancel(Monitor *mon, const QDict *qdict);
+void hmp_dump_set_speed(Monitor *mon, const QDict *qdict);
#endif
diff --git a/qapi-schema.json b/qapi-schema.json
index e5fd056..472eac0 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -1609,3 +1609,18 @@
# Since: 1.1
##
{ 'command': 'dump_cancel' }
+
+##
+# @dump_set_speed
+#
+# Set maximum speed for dumping.
+#
+# @value: maximum speed in bytes.
+#
+# Returns: nothing on success
+#
+# Notes: A value lesser than 1024 will be automatically round up to 1024.
+#
+# Since: 1.1
+##
+{ 'command': 'dump_set_speed', 'data': { 'value': 'int' } }
diff --git a/qmp-commands.hx b/qmp-commands.hx
index c09ca86..73cef06 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -614,6 +614,28 @@ Example:
EQMP
{
+ .name = "dump_set_speed",
+ .args_type = "value:o",
+ .mhandler.cmd_new = qmp_marshal_input_dump_set_speed,
+ },
+
+SQMP
+dump_set_speed
+
+Set maximum speed for dumping.
+
+Arguments:
+
+- "value": maximum speed, in bytes per second (json-int)
+
+Example:
+
+-> { "execute": "dump_set_speed", "arguments": { "value": 1024 } }
+<- { "return": {} }
+
+EQMP
+
+ {
.name = "netdev_add",
.args_type = "netdev:O",
.params = "[user|tap|socket],id=str[,prop=value][,...]",
--
1.7.1
- Re: [Qemu-devel] [RFC][PATCH 10/16 v6] run dump at the background, (continued)
- Re: [Qemu-devel] [RFC][PATCH 10/16 v6] run dump at the background, Jan Kiszka, 2012/02/14
- Re: [Qemu-devel] [RFC][PATCH 10/16 v6] run dump at the background, Jan Kiszka, 2012/02/14
- Re: [Qemu-devel] [RFC][PATCH 10/16 v6] run dump at the background, Wen Congyang, 2012/02/14
- Re: [Qemu-devel] [RFC][PATCH 10/16 v6] run dump at the background, Jan Kiszka, 2012/02/15
- Re: [Qemu-devel] [RFC][PATCH 10/16 v6] run dump at the background, Wen Congyang, 2012/02/15
- Re: [Qemu-devel] [RFC][PATCH 10/16 v6] run dump at the background, Jan Kiszka, 2012/02/15
- Re: [Qemu-devel] [RFC][PATCH 10/16 v6] run dump at the background, Wen Congyang, 2012/02/15
- Re: [Qemu-devel] [RFC][PATCH 10/16 v6] run dump at the background, Jan Kiszka, 2012/02/15
[Qemu-devel] [RFC][PATCH 11/16 v6] support detached dump, Wen Congyang, 2012/02/08
[Qemu-devel] [RFC][PATCH 12/16 v6] support to cancel the current dumping, Wen Congyang, 2012/02/08
[Qemu-devel] [RFC][PATCH 13/16 v6] support to set dumping speed,
Wen Congyang <=
[Qemu-devel] [RFC][PATCH 14/16 v6] support to query dumping status, Wen Congyang, 2012/02/08
[Qemu-devel] [RFC][PATCH 15/16 v6] auto cancel dumping after vm state is changed to run, Wen Congyang, 2012/02/08
[Qemu-devel] [RFC][PATCH 16/16 v6] allow user to dump a fraction of the memory, Wen Congyang, 2012/02/08
Re: [Qemu-devel] [RFC][PATCH 00/16 v6] introducing a new, dedicated memory dump mechanism, Wen Congyang, 2012/02/12