[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] subpages with memory region aliases (was: [PATCH 3/6] kvmva
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] subpages with memory region aliases (was: [PATCH 3/6] kvmvapic: Introduce TPR access optimization for Windows guests) |
Date: |
Thu, 09 Feb 2012 09:35:17 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Avi,
Before I forget:
On 2012-02-05 13:39, Jan Kiszka wrote:
> +static void vapic_map_rom_writable(VAPICROMState *s)
> +{
> + target_phys_addr_t rom_paddr = s->rom_state_paddr & ROM_BLOCK_MASK;
> + MemoryRegionSection section;
> + MemoryRegion *as;
> + size_t rom_size;
> + uint8_t *ram;
> +
> + as = sysbus_address_space(&s->busdev);
> +
> + if (s->rom_mapped_writable) {
> + memory_region_del_subregion(as, &s->rom);
> + memory_region_destroy(&s->rom);
> + }
> +
> + /* grab RAM memory region (region @rom_paddr may still be pc.rom) */
> + section = memory_region_find(as, 0, 1);
> +
> + /* read ROM size from RAM region */
> + ram = memory_region_get_ram_ptr(section.mr);
> + rom_size = ram[rom_paddr + 2] * ROM_BLOCK_SIZE;
> + s->rom_size = rom_size;
> +
> + /* FIXME: round up as everything underneath would fall apart otherwise
> + * (subpages are broken) */
> + rom_size = TARGET_PAGE_ALIGN(rom_size);
Removing this alignment triggers an interesting bug in the memory layer.
Haven't understood the details yet. Is subpage support supposed to work?
> +
> + memory_region_init_alias(&s->rom, "kvmvapic-rom", section.mr, rom_paddr,
> + rom_size);
> + memory_region_add_subregion_overlap(as, rom_paddr, &s->rom, 1000);
> + s->rom_mapped_writable = true;
> +}
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/6] uq/master: TPR access optimization for Windows guests, Jan Kiszka, 2012/02/05
- [Qemu-devel] [PATCH 2/6] kvmvapic: Add option ROM, Jan Kiszka, 2012/02/05
- [Qemu-devel] [PATCH 6/6] kvmvapic: Use optionrom helpers, Jan Kiszka, 2012/02/05
- [Qemu-devel] [PATCH 1/6] target-i386: Add infrastructure for reporting TPR MMIO accesses, Jan Kiszka, 2012/02/05
- [Qemu-devel] [PATCH 5/6] optionsrom: Reserve space for checksum, Jan Kiszka, 2012/02/05
- [Qemu-devel] [PATCH 3/6] kvmvapic: Introduce TPR access optimization for Windows guests, Jan Kiszka, 2012/02/05
- [Qemu-devel] subpages with memory region aliases (was: [PATCH 3/6] kvmvapic: Introduce TPR access optimization for Windows guests),
Jan Kiszka <=
- Re: [Qemu-devel] [PATCH 3/6] kvmvapic: Introduce TPR access optimization for Windows guests, Avi Kivity, 2012/02/09
- Re: [Qemu-devel] [PATCH 3/6] kvmvapic: Introduce TPR access optimization for Windows guests, Jan Kiszka, 2012/02/09
- Re: [Qemu-devel] [PATCH 3/6] kvmvapic: Introduce TPR access optimization for Windows guests, Avi Kivity, 2012/02/09
- Re: [Qemu-devel] [PATCH 3/6] kvmvapic: Introduce TPR access optimization for Windows guests, Jan Kiszka, 2012/02/09
- Re: [Qemu-devel] [PATCH 3/6] kvmvapic: Introduce TPR access optimization for Windows guests, Avi Kivity, 2012/02/09
- Re: [Qemu-devel] [PATCH 3/6] kvmvapic: Introduce TPR access optimization for Windows guests, Jan Kiszka, 2012/02/09
- Re: [Qemu-devel] [PATCH 3/6] kvmvapic: Introduce TPR access optimization for Windows guests, Paolo Bonzini, 2012/02/09